Skip to content

Implement cromulent Copy closure captures - #163717

Draft
Jules-Bertholet wants to merge 2 commits into
rust-lang:mainfrom
Jules-Bertholet:cromulent-copy-closure-captures
Draft

Implement cromulent Copy closure captures#163717
Jules-Bertholet wants to merge 2 commits into
rust-lang:mainfrom
Jules-Bertholet:cromulent-copy-closure-captures

Conversation

@Jules-Bertholet

@Jules-Bertholet Jules-Bertholet commented Oct 3, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Implements rust-lang/rfcs#4011.

@rustbot label T-lang A-closures needs-fcp

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-closures Area: Closures (`|…| { … }`) needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-lang Relevant to the language team labels Oct 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch 2 times, most recently from d0c48eb to 61b2dc2 Compare October 3, 2026 20:36
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 3, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch from 61b2dc2 to 8cf8a71 Compare October 3, 2026 21:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch from 8cf8a71 to cc5b2e6 Compare October 3, 2026 22:40
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch 3 times, most recently from cdb0b2a to aa1f01a Compare October 4, 2026 04:24
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch 3 times, most recently from 40c8217 to 44bd89c Compare October 4, 2026 15:27
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch 3 times, most recently from 03e2c32 to 2a3a2e0 Compare October 4, 2026 19:20
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch 2 times, most recently from 59ad213 to 818ec01 Compare October 4, 2026 21:42
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch from 9790b9f to 1ddfd18 Compare October 6, 2026 14:20
@Jules-Bertholet Jules-Bertholet mentioned this pull request Oct 6, 2026
Merged
@mejrs

mejrs commented Oct 6, 2026

Copy link
Copy Markdown
Member

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Oct 6, 2026
@bors
Auto merge of #163717 - Jules-Bertholet:cromulent-copy-closure-captur…
83e3885 
…es, r=<try>

Implement cromulent Copy closure captures
@rust-bors

rust-bors Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 83e3885 (83e388551a68240a8add01574724ea840a7bbc2a)
Base parent: 8d1a764 (8d1a76430406c877b35d0b627e7f796dcf0dfeca)

@mejrs

mejrs commented Oct 7, 2026

Copy link
Copy Markdown
Member

@craterbot check

@craterbot

craterbot commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-163717 created and queued.
🤖 Automatically detected try build 83e3885
⚠️ Try build based on commit 1ddfd18, but latest commit is 7247983. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163905 - Jules-Bertholet:bootstrap-tweak, r…
92b4936 
…=Kobzol

Remove redundant closure in bootstrap

My PR rust-lang#163717 would make Clippy start linting `redundant_closure_for_method_calls` here; let's get ahead of that.

@rustbot label T-bootstrap
@rustbot ready

r? bootstrap
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163905 - Jules-Bertholet:bootstrap-tweak, r…
74fdbf9 
…=Kobzol

Remove redundant closure in bootstrap

My PR rust-lang#163717 would make Clippy start linting `redundant_closure_for_method_calls` here; let's get ahead of that.

@rustbot label T-bootstrap
@rustbot ready

r? bootstrap
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163905 - Jules-Bertholet:bootstrap-tweak, r…
d171908 
…=Kobzol

Remove redundant closure in bootstrap

My PR rust-lang#163717 would make Clippy start linting `redundant_closure_for_method_calls` here; let's get ahead of that.

@rustbot label T-bootstrap
@rustbot ready

r? bootstrap
rust-bors Bot pushed a commit that referenced this pull request Oct 7, 2026
@bors
Unrolled build for #163905 in rollup 163945
a96c16f 
Rollup merge of #163905 - Jules-Bertholet:bootstrap-tweak, r=Kobzol

Remove redundant closure in bootstrap

My PR #163717 would make Clippy start linting `redundant_closure_for_method_calls` here; let's get ahead of that.

@rustbot label T-bootstrap
@rustbot ready

r? bootstrap
@rust-bors

This comment has been minimized.

Sign in to view
@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch 2 times, most recently from 641f34a to 10eb649 Compare October 8, 2026 01:49
github-actions Bot pushed a commit to rust-lang/stdarch that referenced this pull request Oct 8, 2026
@JonathanBrouwer
Rollup merge of #163905 - Jules-Bertholet:bootstrap-tweak, r=Kobzol
8c87fd9 
Remove redundant closure in bootstrap

My PR rust-lang/rust#163717 would make Clippy start linting `redundant_closure_for_method_calls` here; let's get ahead of that.

@rustbot label T-bootstrap
@rustbot ready

r? bootstrap
Jules-Bertholet
Jules-Bertholet commented Oct 8, 2026
View reviewed changes
Comment thread tests/codegen-llvm/lib-optimizations/append-elements.rs
@@ -13,7 +13,7 @@
#[no_mangle]
pub fn vec_append_with_temp_alloc(dst: &mut Vec<u8>, src: &[u8]) {

@Jules-Bertholet Jules-Bertholet Oct 8, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what is going on here. See https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Help.20debugging.20MIR.20inlining.20change/with/630027294 for discussion

View changes since the review

@Jules-Bertholet
Jules-Bertholet force-pushed the cromulent-copy-closure-captures branch from 10eb649 to 6cd2bdc Compare October 8, 2026 17:15
@Jules-Bertholet Jules-Bertholet mentioned this pull request Oct 9, 2026
Open
@rust-bors

rust-bors Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #164117) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

@theemathas theemathas mentioned this pull request Oct 11, 2026
Draft
@theemathas

theemathas commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Crater rollup in #164148

@craterbot abort

@theemathas

theemathas commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

@craterbot abort

@craterbot

craterbot commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

🗑️ Experiment pr-163717 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-closures Area: Closures (`|…| { … }`) needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Jules-Bertholet @rust-log-analyzer @clarfonthey @rust-timer @mejrs @craterbot @theemathas @rustbot